Switch service feature gates to be auto generated #14494
Conversation
| featuregate.WithRegisterFromVersion("v0.122.0"), | ||
| featuregate.WithRegisterDescription("Allow starting the Collector without starting any pipelines."), | ||
| ) | ||
| AllowNoPipelines = metadata.ServiceAllowNoPipelinesFeatureGate |
There was a problem hiding this comment.
IMHO it would be nice not to make this public. But we use it in otelcol.
There was a problem hiding this comment.
Agreed it would be nice to have it private, but unfortunately the otelcol/service responsibility distinction can be a little fuzzy. It was already public before this PR, so it's fine to leave it for now.
There was a problem hiding this comment.
One thing I've been pondering is whether it would make more sense to have 2 feature gates with the same name.
One in otelcol, and one in service. Then, both could be private. And both components would be documented.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14494 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 677 677
Lines 42699 42699
=======================================
Hits 39219 39219
Misses 2425 2425
Partials 1055 1055 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
evan-bradley
left a comment
evan-bradley
left a comment
There was a problem hiding this comment.
Excited to have this. Thanks.
Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
2 participants
This switches the service's feature gates to be automatically generated, so they are documented as well.
Related: #14067